{"componentChunkName":"component---node-modules-rocketseat-gatsby-theme-docs-core-src-templates-docs-query-js","path":"/code-style/LendingOracleFacetStorage-LOS","result":{"data":{"mdx":{"id":"fe9321bf-4a01-5b8e-ad34-000da83cdc6c","excerpt":"LOS-01C: Inefficient Re-Evaluation of Price Limits Type Severity Location Gas Optimization LendingOracleFacetStorage.sol:L291 Description: The…","fields":{"slug":"/code-style/LendingOracleFacetStorage-LOS/"},"frontmatter":{"title":"LendingOracleFacetStorage Code Style Findings","description":"Contains all the findings that relate to code style on the contract codebase","image":null,"disableTableOfContents":null},"body":"var _excluded = [\"components\"];\n\nfunction _extends() { _extends = Object.assign || function (target) { for (var i = 1; i < arguments.length; i++) { var source = arguments[i]; for (var key in source) { if (Object.prototype.hasOwnProperty.call(source, key)) { target[key] = source[key]; } } } return target; }; return _extends.apply(this, arguments); }\n\nfunction _objectWithoutProperties(source, excluded) { if (source == null) return {}; var target = _objectWithoutPropertiesLoose(source, excluded); var key, i; if (Object.getOwnPropertySymbols) { var sourceSymbolKeys = Object.getOwnPropertySymbols(source); for (i = 0; i < sourceSymbolKeys.length; i++) { key = sourceSymbolKeys[i]; if (excluded.indexOf(key) >= 0) continue; if (!Object.prototype.propertyIsEnumerable.call(source, key)) continue; target[key] = source[key]; } } return target; }\n\nfunction _objectWithoutPropertiesLoose(source, excluded) { if (source == null) return {}; var target = {}; var sourceKeys = Object.keys(source); var key, i; for (i = 0; i < sourceKeys.length; i++) { key = sourceKeys[i]; if (excluded.indexOf(key) >= 0) continue; target[key] = source[key]; } return target; }\n\n/* @jsxRuntime classic */\n\n/* @jsx mdx */\nvar _frontmatter = {\n  \"title\": \"LendingOracleFacetStorage Code Style Findings\",\n  \"description\": \"Contains all the findings that relate to code style on the contract codebase\"\n};\nvar layoutProps = {\n  _frontmatter: _frontmatter\n};\nvar MDXLayout = \"wrapper\";\nreturn function MDXContent(_ref) {\n  var components = _ref.components,\n      props = _objectWithoutProperties(_ref, _excluded);\n\n  return mdx(MDXLayout, _extends({}, layoutProps, props, {\n    components: components,\n    mdxType: \"MDXLayout\"\n  }), mdx(\"h2\", {\n    \"id\": \"span-idlos-01clos-01c-inefficient-re-evaluation-of-price-limitsspan\",\n    \"style\": {\n      \"position\": \"relative\"\n    }\n  }, mdx(\"a\", {\n    parentName: \"h2\",\n    \"href\": \"#span-idlos-01clos-01c-inefficient-re-evaluation-of-price-limitsspan\",\n    \"aria-label\": \"span idlos 01clos 01c inefficient re evaluation of price limitsspan permalink\",\n    \"className\": \"anchor before\"\n  }, mdx(\"svg\", {\n    parentName: \"a\",\n    \"aria-hidden\": \"true\",\n    \"focusable\": \"false\",\n    \"height\": \"16\",\n    \"version\": \"1.1\",\n    \"viewBox\": \"0 0 16 16\",\n    \"width\": \"16\"\n  }, mdx(\"path\", {\n    parentName: \"svg\",\n    \"fillRule\": \"evenodd\",\n    \"d\": \"M4 9h1v1H4c-1.5 0-3-1.69-3-3.5S2.55 3 4 3h4c1.45 0 3 1.69 3 3.5 0 1.41-.91 2.72-2 3.25V8.59c.58-.45 1-1.27 1-2.09C10 5.22 8.98 4 8 4H4c-.98 0-2 1.22-2 2.5S3 9 4 9zm9-3h-1v1h1c1 0 2 1.22 2 2.5S13.98 12 13 12H9c-.98 0-2-1.22-2-2.5 0-.83.42-1.64 1-2.09V6.25c-1.09.53-2 1.84-2 3.25C6 11.31 7.55 13 9 13h4c1.45 0 3-1.69 3-3.5S14.5 6 13 6z\"\n  }))), mdx(\"span\", {\n    id: \"LOS-01C\"\n  }, \"LOS-01C: Inefficient Re-Evaluation of Price Limits\")), mdx(\"table\", null, mdx(\"thead\", {\n    parentName: \"table\"\n  }, mdx(\"tr\", {\n    parentName: \"thead\"\n  }, mdx(\"th\", {\n    parentName: \"tr\",\n    \"align\": null\n  }, \"Type\"), mdx(\"th\", {\n    parentName: \"tr\",\n    \"align\": null\n  }, \"Severity\"), mdx(\"th\", {\n    parentName: \"tr\",\n    \"align\": null\n  }, \"Location\"))), mdx(\"tbody\", {\n    parentName: \"table\"\n  }, mdx(\"tr\", {\n    parentName: \"tbody\"\n  }, mdx(\"td\", {\n    parentName: \"tr\",\n    \"align\": null\n  }, mdx(\"a\", {\n    parentName: \"td\",\n    \"href\": \"/reports/nexera-core-tokenization-system-update-6810dab7860d510018e9c07c/appendix/finding-types#gas-optimization\"\n  }, \"Gas Optimization\")), mdx(\"td\", {\n    parentName: \"tr\",\n    \"align\": null\n  }, mdx(\"img\", {\n    parentName: \"td\",\n    \"className\": \"o-severity o-informational\",\n    \"src\": \"https://omniscia.io/report-assets/informational.png\"\n  })), mdx(\"td\", {\n    parentName: \"tr\",\n    \"align\": null\n  }, mdx(\"a\", {\n    parentName: \"td\",\n    \"href\": \"https://github.com/evergonlabs/TMI-tokenizer/blob/2695e5b65e872ec0df628769047e38d21ee14bb0/packages/contracts/contracts/oracleFacets/lendingOracle/LendingOracleFacetStorage.sol#L291\"\n  }, \"LendingOracleFacetStorage.sol:L291\"))))), mdx(\"h3\", {\n    \"id\": \"description\",\n    \"style\": {\n      \"position\": \"relative\"\n    }\n  }, mdx(\"a\", {\n    parentName: \"h3\",\n    \"href\": \"#description\",\n    \"aria-label\": \"description permalink\",\n    \"className\": \"anchor before\"\n  }, mdx(\"svg\", {\n    parentName: \"a\",\n    \"aria-hidden\": \"true\",\n    \"focusable\": \"false\",\n    \"height\": \"16\",\n    \"version\": \"1.1\",\n    \"viewBox\": \"0 0 16 16\",\n    \"width\": \"16\"\n  }, mdx(\"path\", {\n    parentName: \"svg\",\n    \"fillRule\": \"evenodd\",\n    \"d\": \"M4 9h1v1H4c-1.5 0-3-1.69-3-3.5S2.55 3 4 3h4c1.45 0 3 1.69 3 3.5 0 1.41-.91 2.72-2 3.25V8.59c.58-.45 1-1.27 1-2.09C10 5.22 8.98 4 8 4H4c-.98 0-2 1.22-2 2.5S3 9 4 9zm9-3h-1v1h1c1 0 2 1.22 2 2.5S13.98 12 13 12H9c-.98 0-2-1.22-2-2.5 0-.83.42-1.64 1-2.09V6.25c-1.09.53-2 1.84-2 3.25C6 11.31 7.55 13 9 13h4c1.45 0 3-1.69 3-3.5S14.5 6 13 6z\"\n  }))), \"Description:\"), mdx(\"p\", null, \"The \", mdx(\"a\", {\n    parentName: \"p\",\n    \"href\": \"https://github.com/evergonlabs/TMI-tokenizer/blob/2695e5b65e872ec0df628769047e38d21ee14bb0/packages/contracts/contracts/oracleFacets/lendingOracle/LendingOracleFacetStorage.sol#L276-L292\"\n  }, mdx(\"inlineCode\", {\n    parentName: \"a\"\n  }, \"LendingOracleFacetStorage::removeMarginFromPriceLimits\")), \" function will invoke the \", mdx(\"a\", {\n    parentName: \"p\",\n    \"href\": \"https://github.com/evergonlabs/TMI-tokenizer/blob/2695e5b65e872ec0df628769047e38d21ee14bb0/packages/contracts/contracts/oracleFacets/lendingOracle/LendingOracleFacetStorage.sol#L187-L274\"\n  }, mdx(\"inlineCode\", {\n    parentName: \"a\"\n  }, \"LendingOracleFacetStorage::setCollateralPrice\")), \" function which will in turn reset the \", mdx(\"inlineCode\", {\n    parentName: \"p\"\n  }, \"currentCollateralPrice\"), \" to the same value.\"), mdx(\"h3\", {\n    \"id\": \"example\",\n    \"style\": {\n      \"position\": \"relative\"\n    }\n  }, mdx(\"a\", {\n    parentName: \"h3\",\n    \"href\": \"#example\",\n    \"aria-label\": \"example permalink\",\n    \"className\": \"anchor before\"\n  }, mdx(\"svg\", {\n    parentName: \"a\",\n    \"aria-hidden\": \"true\",\n    \"focusable\": \"false\",\n    \"height\": \"16\",\n    \"version\": \"1.1\",\n    \"viewBox\": \"0 0 16 16\",\n    \"width\": \"16\"\n  }, mdx(\"path\", {\n    parentName: \"svg\",\n    \"fillRule\": \"evenodd\",\n    \"d\": \"M4 9h1v1H4c-1.5 0-3-1.69-3-3.5S2.55 3 4 3h4c1.45 0 3 1.69 3 3.5 0 1.41-.91 2.72-2 3.25V8.59c.58-.45 1-1.27 1-2.09C10 5.22 8.98 4 8 4H4c-.98 0-2 1.22-2 2.5S3 9 4 9zm9-3h-1v1h1c1 0 2 1.22 2 2.5S13.98 12 13 12H9c-.98 0-2-1.22-2-2.5 0-.83.42-1.64 1-2.09V6.25c-1.09.53-2 1.84-2 3.25C6 11.31 7.55 13 9 13h4c1.45 0 3-1.69 3-3.5S14.5 6 13 6z\"\n  }))), \"Example:\"), mdx(\"pre\", null, mdx(\"code\", {\n    parentName: \"pre\",\n    \"className\": \"language-sol\",\n    \"metastring\": \"title=packages/contracts/contracts/oracleFacets/lendingOracle/LendingOracleFacetStorage.sol highlight={16} lineNumbers=true lineOffset=275\",\n    \"title\": \"packages/contracts/contracts/oracleFacets/lendingOracle/LendingOracleFacetStorage.sol\",\n    \"highlight\": \"{16}\",\n    \"lineNumbers\": \"true\",\n    \"lineOffset\": \"275\"\n  }, \"function removeMarginFromPriceLimits(Layout storage l, uint256 campaignId, uint256 packetsMarginAmount) internal {\\n    CampaignDetails storage campaignDetails = l.campaignDetails[campaignId];\\n    if (campaignDetails.priceLimits[0] <= packetsMarginAmount) revert packetsMarginAmountEnoughForBuyback();\\n\\n    uint256 length = campaignDetails.priceLimits.length;\\n\\n    for (uint256 i; i < length; ) {\\n        // Derived after execution of `setPriceLimitsOnPostReceive()`:\\n        // priceLimits[i] >= priceLimits[0], \\u2200i \\u2208 {1, \\u2026, n} where n = dim(priceLimits) - 1\\n        unchecked {\\n            campaignDetails.priceLimits[i] -= packetsMarginAmount;\\n            i += 1;\\n        }\\n    }\\n\\n    setCollateralPrice(l, campaignId, campaignDetails.currentCollateralPrice);\\n}\\n\")), mdx(\"h3\", {\n    \"id\": \"recommendation\",\n    \"style\": {\n      \"position\": \"relative\"\n    }\n  }, mdx(\"a\", {\n    parentName: \"h3\",\n    \"href\": \"#recommendation\",\n    \"aria-label\": \"recommendation permalink\",\n    \"className\": \"anchor before\"\n  }, mdx(\"svg\", {\n    parentName: \"a\",\n    \"aria-hidden\": \"true\",\n    \"focusable\": \"false\",\n    \"height\": \"16\",\n    \"version\": \"1.1\",\n    \"viewBox\": \"0 0 16 16\",\n    \"width\": \"16\"\n  }, mdx(\"path\", {\n    parentName: \"svg\",\n    \"fillRule\": \"evenodd\",\n    \"d\": \"M4 9h1v1H4c-1.5 0-3-1.69-3-3.5S2.55 3 4 3h4c1.45 0 3 1.69 3 3.5 0 1.41-.91 2.72-2 3.25V8.59c.58-.45 1-1.27 1-2.09C10 5.22 8.98 4 8 4H4c-.98 0-2 1.22-2 2.5S3 9 4 9zm9-3h-1v1h1c1 0 2 1.22 2 2.5S13.98 12 13 12H9c-.98 0-2-1.22-2-2.5 0-.83.42-1.64 1-2.09V6.25c-1.09.53-2 1.84-2 3.25C6 11.31 7.55 13 9 13h4c1.45 0 3-1.69 3-3.5S14.5 6 13 6z\"\n  }))), \"Recommendation:\"), mdx(\"p\", null, \"We advise the code of \", mdx(\"a\", {\n    parentName: \"p\",\n    \"href\": \"https://github.com/evergonlabs/TMI-tokenizer/blob/2695e5b65e872ec0df628769047e38d21ee14bb0/packages/contracts/contracts/oracleFacets/lendingOracle/LendingOracleFacetStorage.sol#L187-L274\"\n  }, mdx(\"inlineCode\", {\n    parentName: \"a\"\n  }, \"LendingOracleFacetStorage::setCollateralPrice\")), \" to be refactored so as to split the assignment logic from the price limit iterations, permitting the price limits to be enforced efficiently when removing margin.\"), mdx(\"h3\", {\n    \"id\": \"alleviation-d682057ecb0e254069773d64f32c068cedb71e2a\",\n    \"style\": {\n      \"position\": \"relative\"\n    }\n  }, mdx(\"a\", {\n    parentName: \"h3\",\n    \"href\": \"#alleviation-d682057ecb0e254069773d64f32c068cedb71e2a\",\n    \"aria-label\": \"alleviation d682057ecb0e254069773d64f32c068cedb71e2a permalink\",\n    \"className\": \"anchor before\"\n  }, mdx(\"svg\", {\n    parentName: \"a\",\n    \"aria-hidden\": \"true\",\n    \"focusable\": \"false\",\n    \"height\": \"16\",\n    \"version\": \"1.1\",\n    \"viewBox\": \"0 0 16 16\",\n    \"width\": \"16\"\n  }, mdx(\"path\", {\n    parentName: \"svg\",\n    \"fillRule\": \"evenodd\",\n    \"d\": \"M4 9h1v1H4c-1.5 0-3-1.69-3-3.5S2.55 3 4 3h4c1.45 0 3 1.69 3 3.5 0 1.41-.91 2.72-2 3.25V8.59c.58-.45 1-1.27 1-2.09C10 5.22 8.98 4 8 4H4c-.98 0-2 1.22-2 2.5S3 9 4 9zm9-3h-1v1h1c1 0 2 1.22 2 2.5S13.98 12 13 12H9c-.98 0-2-1.22-2-2.5 0-.83.42-1.64 1-2.09V6.25c-1.09.53-2 1.84-2 3.25C6 11.31 7.55 13 9 13h4c1.45 0 3-1.69 3-3.5S14.5 6 13 6z\"\n  }))), \"Alleviation (d682057ecb0e254069773d64f32c068cedb71e2a):\"), mdx(\"p\", null, \"The recommended optimization has been applied to the codebase alongside a refactor of the price limit traversal mechanisms.\"), mdx(ViewDiffButton, {\n    repoUrl: \"https://github.com/evergonlabs/TMI-tokenizer\",\n    mainHash: \"2695e5b65e872ec0df628769047e38d21ee14bb0\",\n    fixHash: \"d682057ecb0e254069773d64f32c068cedb71e2a\",\n    gitHubIssue: \"357\",\n    mdxType: \"ViewDiffButton\"\n  }));\n}\n;\nMDXContent.isMDXComponent = true;","headings":[{"depth":2,"value":"<span id=\"LOS-01C\">LOS-01C: Inefficient Re-Evaluation of Price Limits</span>"},{"depth":3,"value":"Description:"},{"depth":3,"value":"Example:"},{"depth":3,"value":"Recommendation:"},{"depth":3,"value":"Alleviation (d682057ecb0e254069773d64f32c068cedb71e2a):"}]}},"pageContext":{"slug":"/code-style/LendingOracleFacetStorage-LOS/","prev":{"label":"FundingErc20PacketsFacetStorage.sol (FEF-C)","link":"/code-style/FundingErc20PacketsFacetStorage-FEF"},"next":{"label":"LostAccountRoleEligibilityFacetStorage.sol (LAE-C)","link":"/code-style/LostAccountRoleEligibilityFacetStorage-LAE"}}},"staticQueryHashes":["1954253342","2328931024","2501019404","973074209"]}